ansible/awx

Empty value in execution_environment should remove selections (ansible.controller.job_template)

Open

#14,841 opened on 2024年2月3日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Python (13,071 stars) (3,333 forks)batch import
communitycomponent:awx_collectiongood first issuetype:bug

説明

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.
  • I am NOT reporting a (potential) security vulnerability. (These should be emailed to security@ansible.com instead.)

Bug Summary

When a template has Execution Environment selected but playbook specifies execution_environment = "", the selection in the template should be removed.

AWX version

23.2.0

Select the relevant components

  • UI
  • UI (tech preview)
  • API
  • Docs
  • Collection
  • CLI
  • Other

Installation method

docker development environment

Modifications

no

Ansible version

2.14.2

Operating system

Red Hat Enterprise Linux release 9.1 (Plow)

Web browser

Chrome

Steps to reproduce

- name: Get all templates from AAP
  ansible.controller.export:
    job_templates: 'all'
  register: aap_templates

- debug:
    var: aap_templates.assets.job_templates[0].execution_environment

- set_fact:
    ee: ""

- name: Create templates
  ansible.controller.job_template:
    name: "{{ aap_templates.assets.job_templates[0].name }}"
    execution_environment: "{{ ee }}"

Expected results

TASK [Create templates] ************************************************************************************************************************************ changed: [localhost]

Actual results

TASK [Get all templates from AAP] ************************************************************************************************************************** ok: [localhost]

TASK [debug] *********************************************************************************************************************************************** ok: [localhost] => { "aap_templates.assets.job_templates[0].execution_environment": { "name": "Automation Hub Default execution environment", "type": "execution_environment" } }

TASK [set_fact] ******************************************************************************************************************************************** ok: [localhost]

TASK [Create templates] ************************************************************************************************************************************ ok: [localhost]

Additional information

No response

コントリビューターガイド

技術スタック
python
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Ansible basicsPythonAWX collection structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Examine the job template module in the AWX collection (likely awx collection/modules/job template.py) to understand how the execution environment parameter is processed. Look for where the value is validated or assigned to the task body. The bug appears to be that an empty string is not treated as removal of the execution environment; it should trigger setting the field to null or omitting it. Check if there is any handling for empty string versus None. Also review the existing tests for this module to see if they cover this case.
Empty value in execution_environment should remove selections (ansible.controller.job_template) · ansible/awx#14841 | Good First Issue