ansible/awx

Fix Delinea imports and import test

Open

#14,703 opened on 2023年12月5日

GitHub で見る
 (3 comments) (0 reactions) (1 assignee)Python (13,071 stars) (3,333 forks)batch import
blockedcomponent:apigood first issuetype:bug

説明

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.
  • I am NOT reporting a (potential) security vulnerability. (These should be emailed to security@ansible.com instead.)

Bug Summary

DomainPasswordGrantAuthorizer is unused in awx/main/credential_plugins/tss.py. Flake8 will most likely catch this on the next run so just want to get ahead of this.

awx/main/tests/functional/test_credential_plugins.py will also need to be adjusted for its removal.

AWX version

devel

Select the relevant components

  • UI
  • UI (tech preview)
  • API
  • Docs
  • Collection
  • CLI
  • Other

Installation method

N/A

Modifications

no

Ansible version

n/a

Operating system

n/a

Web browser

No response

Steps to reproduce

Run flake8 and functional tests locally, they will fail with unused imports.

Expected results

Tests pass without issue.

Actual results

ImportError: cannot import name 'DomainPasswordGrantAuthorizer' from 'awx.main.credential_plugins.tss' (/awx_devel/awx/main/credential_plugins/tss.py) or an unused import: DomainPasswordGrantAuthorizer is imported but not used will show up

Additional information

We can remove the try except block now as well if we want as the requirements file has been updated. I will pick this up if no one from the community wants to take it up

コントリビューターガイド

技術スタック
python
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Pythonpytestbasic AWX project structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
The issue involves removing the unused import of `DomainPasswordGrantAuthorizer` in `awx/main/credential plugins/tss.py` and adjusting the test in `awx/main/tests/functional/test credential plugins.py` accordingly. The issue author mentioned they can also remove the try except block if desired. Review the flake8 output and run functional tests to verify the fix. Look at the file history for the tss.py to understand the context of the import.