angular/components

mat-icon has display issues when inlining multiple copies of the same SVG with defs with IDs

Open

#9,529 opened on 2018年1月23日

GitHub で見る
 (4 comments) (4 reactions) (0 assignees)TypeScript (24,044 stars) (6,650 forks)batch import
P4area: material/iconhelp wanted

説明

Bug, feature request, or proposal:

Proposal: Extend the cloneSvg function in src/lib/icon/icon-registry.ts to accommodate munging IDs in defs so that multiple copies of the same inlined SVG won't have conflicting IDs.

What is the expected behavior?

When two copies of an SVG with a linearGradient def (identified by an ID) are inlined, both copies of the SVG should display the linear gradient.

What is the current behavior?

Only the first copy of the SVG displays the linear gradient. All other copies do not, because the IDs in the defs are duplicated in the other copies.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 5.1.2, Angular Material 5.0.2 (although the issue still exists in 5.1.0), TypeScript 2.6.2. Tested in Win10 in Chrome Version 63.0.3239.132 (Official Build) (64-bit).

コントリビューターガイド

技術スタック
angulartypescript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Angular Material basicsTypeScriptSVG defsicon registry.ts
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the cloneSvg function in src/lib/icon/icon registry.ts. Understand how SVGs are currently cloned and where IDs are duplicated. Consider appending unique suffixes to IDs in defs for each cloned SVG copy. Check existing tests and verify behavior.
mat-icon has display issues when inlining multiple copies of the same SVG with defs with IDs · angular/components#9529 | Good First Issue