expanded/collapsed state not restored on saveState.restore · angular-ui/ui-grid#6718

(3 comments) (2 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import

good first issue

説明

I traced the code in grouping.js and found the issue at line 808 when the applyRowExpandedStates is called, the first argument "grid.grouping.groupingHeaderCache" is an empty object.

My theory is that the grouping that was just applied a few lines above didn't apply yet and therefore the groupingHeaderCache was not yet set.

To prove my theory, i added a setTimeout to line 808 as follows:

if ( config.rowExpandedStates ){
          setTimeout(function(){service.applyRowExpandedStates( grid.grouping.groupingHeaderCache, config.rowExpandedStates )});
        }

and that made it work.

Can you guys look into this and provide a fix if this is indeed a bug? and I think it is because even on your tutorial page http://ui-grid.info/docs/#!/tutorial/208_save_state, the state of expanded rows is not restored. To reproduce it there, you need to group on a column, expand one and Save. Then ungroup and restore. .

コントリビューターガイド

技術スタック: javascriptangular
領域: frontend
Issue 種別: bug
難度: 3
推定時間: half day
活動状況: stale
明確さ: clear
前提条件: Angularui grid knowledgeunderstanding of async rendering
初心者向け度: 35
調査方針: The issue is in grouping.js at line 808 where applyRowExpandedStates is called with an empty groupingHeaderCache. Investigate why the cache is empty at that point; a workaround using setTimeout suggests an async timing issue. Check the save/restore flow to ensure grouping is fully applied before restoring expanded states. Look for existing comments or PRs related to this bug.