angular-ui/ui-grid

CellNav prevents menu from closing

Open

#5,734 opened on 2016年10月11日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

When cellNav is turned on, it has a stopPropogation on the cell element that prevents the grid/column menu from closing.

To see any example, go to the cellNav tutorial: http://ui-grid.info/docs/#/tutorial/202_cellnav

navigate through some cells, open up a menu, then click away from the menu

Result: the menu remains open Expected Result: the menu would close

This is due to the stopPropogation in the cellNav click event:

https://github.com/angular-ui/ui-grid/blob/master/src/features/cellnav/js/cellnav.js#L1044-L1045

This prevents the menu hide event from occurring:

https://github.com/angular-ui/ui-grid/blob/master/src/js/core/directives/ui-grid-menu.js#L111

What is the need/reason behind the stopPropogation in cellNav?

コントリビューターガイド