angular-ui/ui-grid

saveState.save and saveState.restore selects incorrect items in the grid if a filter is present

Open

#5,663 opened on 2016年9月7日

GitHub で見る
 (1 comment) (1 reaction) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

説明

If you have say, a grid with 10 items in it and apply a filter that results in rows 6 - 10 being shown, select all of them and then invoke saveState.save then saveState.restore row 6 - 10 are not selected. If you then remove the filter you will find that rows 1-5 are selected.

Looking at what saveState.save produces it seems that the stored selections are row indexes for the filtered selection: "selection":[{"identity":false,"row":0},{"identity":false,"row":1},... But are reapplied to the grid as a whole.

This can be demonstrated using the grid here http://ui-grid.info/docs/#/tutorial/208_save_state Type B in the 'Company' filter and select the top 3 rows. Hit the Save button. Remove the selections and the Company filter. Hit the Restore button.

The filter is applied but nothing appears to be selected. Remove the filter and you will find the top 3 rows of the grid selected.

コントリビューターガイド

技術スタック
javascriptangular
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with ui gridAngularJS basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Investigate the saveState service in ui grid, specifically the save and restore methods. Check how selection indices are stored and restored relative to filtered data. The issue indicates that row indices are saved based on filtered view but restored as absolute indices. Look for the relevant files in the grid's source code, such as the saveState.js or similar, to understand how filter state is handled. Test with the provided reproduction steps to confirm the bug.