angular-ui/ui-grid

Editing a cell partially in view fails

Open

#5,161 opened on 2016年2月23日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

説明

This happens when there are enough rows to warrant vertical scrolling. You can kind of see what's happening better on IE11, but it fails in Chrome too.

http://plnkr.co/edit/H7q2BsQupSBI4Um1BmUt?p=preview

Steps to reproduce:

  1. Scroll to bottom row.
  2. Row 3 should be about half visible.
  3. Double-click the "Gender" column on row 3 to begin editing.
  4. Row 3 scrolls into view and the editor starts and stops instantly.
  5. If you haven't manually scrolled, none of the edits for row 3 work until you scroll.

From the debugging I've done, when beginEditAfterScroll() in the uiGridCell directive runs, it sets up the deregOnGridScroll() function. This function is invoked immediately after edit begins so the edit is immediately canceled.

It may be that Grid.prototype.scrollToIfNecessary() is trying to scroll when its not needed.

コントリビューターガイド

技術スタック
angularjavascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
AngularJS basicsUI Grid internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the `beginEditAfterScroll()` function in the `uiGridCell` directive and the `scrollToIfNecessary()` method in `Grid.prototype`. The issue mentions that editing starts and stops instantly due to the deregOnGridScroll function being invoked immediately. Focus on why scrolling occurs for partially visible rows and whether the scroll condition is unnecessary.