angular-ui/ui-grid

uiGridValidateService.setValidator have newValue & oldValue param values reversed

Open

#5,059 opened on 2016年2月3日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

I was testing the sample in Plunkr and printed the newValue and oldValue parameters. Their values have been reversed. "NewValue" is showing old value and vice versa. Below is documented function with 2 alert statements.

uiGridValidateService.setValidator('startWith', function(argument) { return function(newValue, oldValue, rowEntity, colDef) { if (!newValue) { return true; // We should not test for existence here } else { alert('newValue ' + newValue); alert('oldValue ' + oldValue); return newValue.startsWith(argument); } }; }, function(argument) { return 'You can only insert names starting with: "' + argument + '"'; }

);

  • Nishat.

コントリビューターガイド