angular-ui/ui-grid
GitHub で見るGridRenderContainer.prototype.getMargin seems to to slowdown apps
Open
#4,909 opened on 2015年12月27日
help wantedseverity: performance
Repository metrics
- Stars
- (5,395 stars)
- PR merge metrics
- (30d に merged PR はありません)
説明
I profiled one of my apps with Batarang. i noticed that for a page with six smaller ui grid instances the GridRenderContainer.prototype.getMargin takes about 60% of the cpu time.
The method is called from a template:
$templateCache.put('ui-grid/uiGridRenderContainer', ...{ 'margin-left': colContainer.getMargin('left') + 'px', 'margin-right': colContainer.getMargin('right') + 'px' }...
The function loops over viewportAdjusters. Maybe it is worthwhile to optimize the method. For example, it filters out the adjustment results of many of the calls made:
if (adjustment.side && adjustment.side === side)
Such calls could be avoided. Or maybe there is a way to cache the margins and avoid the loop altogether.