angular-ui/ui-grid

Table data not rendering properly during the timeout

Open

#4,564 opened on 2015年10月23日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

説明

Hi,

I have an issue with the output of table data during the database call for $http.post request in my original code. I have added an $http.get and explicit timeout here to reproduce the issue. Plunker is below.

There might be some redundant code here, but I wanted to keep it as close as possible to my original code. Some stuff I had to remove. The idea is to put and remove dynamically a secondary sort which would be applied on appropriate column and reset it everytime on a new submit.

How to reproduce: Click on Tab 2 - click on any radio button - press submit. Observe that during the timeout the table data is being rendered wrong. After timeout, the data is displayed properly and appropriate sort is applied.

Why the table data is messed up during the timeout? I tried to use notifyDataChange(uiGridConstants.dataChange.ALL) and refresh(), but it didn't help. Is there a way to fix it?

http://plnkr.co/edit/N0PuWgzoHcOWAdXfKntt?p=preview

Thanks

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
AngularJSui grid experience
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Investigate the provided Plunker (http://plnkr.co/edit/N0PuWgzoHcOWAdXfKntt?p=preview). The issue occurs during a timeout when table data is rendered incorrectly. Look into ui grid's `notifyDataChange` and `refresh` methods. Check the $http.get call and how the secondary sort is applied. The bug may relate to asynchronous data updates and grid rendering cycle. Consider the ui grid source code for data binding during timeouts.