Invalid arguments provided in click handler of selectionSelectAllButtons & treeBaseExpandAllButtons · angular-ui/ui-grid#4551

(0 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import

good first issuegrid-selection

説明

Hi,

there is a bug in the ui-grid/selectionSelectAllButtons template or its directive: the click handler in directive uiGridSelectionSelectAllButtons is expecting 2 arguments:

$scope.headerButtonClick = function(row, evt) { }

but only the $event argument is provided, resulting in a wrongly assigned argument (i.e. event is passed as the row argument). You should either fix the template or modify the directive. The same goes for the uiGridTreeBaseExpandAllButtons directive btw.

NB I suggest you modify the templates to

ng-click="headerButtonClick(null, $event)"

because then you keep your code in line with the other templates (e.g. selectionRowHeaderButtons.html)

コントリビューターガイド

技術スタック: javascript
領域: frontend
Issue 種別: bug
難度: 2
推定時間: under 1 hour
活動状況: stale
明確さ: clear
前提条件: AngularJS template basics
初心者向け度: 70
調査方針: The bug is in two template files: selectionSelectAllButtons.html and treeBaseExpandAllButtons.html. The click handler `headerButtonClick(row, evt)` expects two arguments but only `$event` is passed. The suggested fix is to change the ng click to `headerButtonClick(null, $event)` in both templates. No linked PRs or comments exist.