angular-ui/ui-grid

Selected row count in grid footer not updated when rows deleted programmatically

Open

#4,100 opened on 2015年8月3日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuetype: bugworkaround

説明

Deleting gird rows with gridOptions.data.splice does not update girdFooter selected row counts.

See http://plnkr.co/edit/a7GogUdI5nDUvc2KN1Rt?p=preview

Example is a fork of Tutorial: 210 Selection.

$scope.deleteSelected = function() {
      var rowsToDelete;
      rowsToDelete = $scope.gridApi.selection.getSelectedRows();
      if (rowsToDelete.length) {
        rowEntity = rowsToDelete[0];
        rowIndexToDelete = $scope.gridOptions.data.indexOf(rowEntity);
        $scope.gridOptions.data.splice(rowIndexToDelete, 1);
      }
   }

Steps to reproduce

  1. select row
  2. press 'Delete selected row' button, which fires $scope.deleteSelected
  3. footer still indicates deleted row is selected (selected row count does not decrement)

Before

plunker

After

plunker

コントリビューターガイド

技術スタック
javascriptangular
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
AngularJS basicsui grid selection API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate why the grid footer's selected row count is not updated when rows are deleted programmatically using splice. The issue is that splicing gridOptions.data does not trigger the grid's internal selection update. Look at the selection module in ui grid (likely in src/features/selection/) to understand how selected row counts are tracked and updated. The solution may involve using the grid API's deleteRow method or calling gridApi.selection.validateSelection() after data mutation. The plunker linked in the issue provides a reproduction. See if there are any existing tests or PRs related to this.