angular-ui/ui-grid

Refactor removed ability to handle Enter & arrow keys on grid

Open

#3,805 opened on 2015年6月18日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

説明

Refactor: https://github.com/angular-ui/ng-grid/pull/3120 says this:

The problem is that viewPortKeyDown does not get called for navigation keystrokes (specifically Enter and Left/Right Arrow). Previous to this refactor, we could attach an ng-keydown in a cell template to handle these keys.

We desperately need this, as the Enter key lets us submit the form the user is on and the left/right arrow keys let us scroll the grid immediately, irrespective of which column has focus.

I can try to submit a bug fix if that's preferred, though I might not implement it properly...

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptAngularJSui grid codebase
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Investigate the refactor in PR #3120 which changed key event handling. Look at the cellNav feature code in source/features/cellnav/ directory, particularly how viewPortKeyDown is implemented and why it doesn't fire for navigation keys like Enter and arrows. Compare with the old behavior where ng keydown in cell templates was used. Consider extending viewPortKeyDown to include these keys or provide a new API.