Enhancement: Remove serve-favicon dependency · angular-fullstack/generator-angular-fullstack#2640

(1 comment) (0 reactions) (0 assignees)JavaScript (6,134 stars) (1,268 forks)batch import

Help Wantedchoreenhancement

説明

The philosophy behind the serve-favicon module is rather outdated, almost nobody knows or cares about creating .ico files. Everyone just puts .png or .gif files now (Mac and iOS ignore .ico anyway). But omitting the favicon.ico file makes the app crash in production environment because of the serve-favicon dependency.

Please consider removing this module and adding support for the modern icons required by the newer OSs, by adding these lines in _index.html:

  <link rel="icon" type="image/png" href="/favicon.png">
  <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="96x96" href="/favicon-96x96.png">
  <link rel="apple-touch-icon" href="/favicon_120_retina.png">
  <link rel="apple-touch-icon" sizes="152x152" href="/favicon_152_retina.png">
  <link rel="apple-touch-icon" sizes="167x167" href="/favicon_167.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/favicon_180.png">

コントリビューターガイド

技術スタック: javascriptnodejsexpressangularhtmlcss
領域: frontendbackend
Issue 種別: feature
難度: 2
推定時間: under 1 hour
活動状況: stale
明確さ: clear
前提条件: basic HTML knowledgeNode.js project structure
初心者向け度: 90
調査方針: The issue requires removing the serve favicon dependency from the project's package.json and updating the index.html to include the provided favicon link tags. The file index.html is likely in the app's template directory. No linked PRs or comments indicate any ongoing work. The main task is to update the template and configuration.