angular-fullstack/generator-angular-fullstack

Should client/app/admin and account be full components?

Open

#2,490 opened on 2017年2月4日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,134 stars) (1,268 forks)batch import
Help Wanted

説明

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.2
Node 6.9.4
npm 4.1.2
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB Sequelize 4.0.0-2 / PostgreSQL 9.6.1
Auth Y

account(auth) and admin(auth) are implemented as loosely coupled controllers. Their implementation differs from the generated main component (which is an AngularJS component). Also, possibly change their controllerAs to $ctrl from vm.

What are your thoughts about making admin, login, settings, and signup into full AngularJS components? This would improve consistency as well as lay the foundation for those moving to 2.0.

コントリビューターガイド

技術スタック
javascriptangularnodejsexpresspostgresql
領域
frontenddeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
AngularJS component basicsYeoman generator structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Review the current implementation of admin, login, settings, and signup controllers in the templates/app/client/app/account(auth)/ and admin(auth)/ directories. Compare with the main component example at templates/app/client/app/main/main.component.js. Plan to refactor each controller into a full AngularJS component with its own template and controllerAs '$ctrl'. Ensure consistency with the main component structure.