ampproject/amphtml

Consolidate image serving in examples and test/manual

Open

#25,045 opened on 2019年10月14日

GitHub で見る
 (14 comments) (0 reactions) (0 assignees)JavaScript (14,907 stars) (4,096 forks)batch import
Component: amp-imgCustomer: DeveloperP3: When PossibleType: Feature RequestType: RefactoringWG: componentsgood first issue

説明

We currently use a variety of images from all over the internet, including picsum, placekitten, placepuppy, etc. Our images in examples/img are slightly out of date. We should revamp the images in examples/img and possibly document recommendations for them so we can serve all test images within the repo.

コントリビューターガイド

技術スタック
javascripthtmlcss
領域
documentationfrontend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
なし
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue proposes consolidating image sources currently using various external services (picsum, placekitten, placepuppy) into local images under examples/img. The task involves updating these images, potentially removing outdated ones, and documenting the recommended approach for using images in examples and tests. Look at the current state of examples/img and the list of external image references in the codebase (e.g., in examples and test/manual). The issue mentions a need to serve all test images within the repo. Consider adding a script to generate placeholder images if needed. There are 14 comments; review them for any additional context or constraints. Maintainer input may be needed to finalize the set of images.