alteryx/featuretools

Add tests that confirm primitive input_types are the expected shapes

Open

#2,086 opened on 2022年5月19日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)Python (6,895 stars) (853 forks)batch import
good first issue

説明

There are a number of assumptions we make about the shape of Primitive input_types lists:

  • Its either a list of ColumnSchema objects or a list of lists of ColumnSchema objects (and not a combination)
  • All sub-lists are the same length
  • No input_types list or sublist is empty

As we may need to rely on these assumptions at some point, we should add tests that confirm these assumptions for all primitives, so that if we add a Primitive that breaks any of these assumptions in the future, we are notified.

コントリビューターガイド

技術スタック
python
領域
testing
Issue 種別
test
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
PythonpytestFeaturetools Primitive API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
Locate the test files for primitives in the repository (likely under featuretools/tests/primitive tests/). Create a new test function that iterates over all registered primitives and validates the assumptions listed in the issue: that input types is either a list of ColumnSchema or a list of lists of ColumnSchema, that all sub lists have equal length, and that no list or sublist is empty. Use pytest to assert these conditions for each primitive. Ensure to import the necessary modules and check the PrimitiveBase class.
Add tests that confirm primitive input_types are the expected shapes · alteryx/featuretools#2086 | Good First Issue