alexa-pi/AlexaPi

Reusing the config file on install skips authorization

Open

#186 opened on 2017年3月4日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Python (1,324 stars) (402 forks)batch import
bugenhancementhelp wantedrequest

説明

Your OS (including version) where you are running AlexaPi:

OSMC (Debian 8.7)

Your hardware platform and model you are running on:

Raspberry PI 2

Python release (python2 --version):

Python 2.7.9

Description of problem:

If you already have a config file the installer will ask if you want to Keep, Edit or Delete, choosing Keep it does exit the installer even if there is no token saved in the config file. You need to run manually python auth_web.py to finish the configuration.

Expected:

Check if there is a token and is not expired and only then skip the authorization part.

Problem-relevant config.yaml entries:

Steps to reproduce:

  1. Install AlexaPi and kill or get an error after config is created but before authorization is saved
  2. Try to install again

Traceback (if applicable):

Additional info:

コントリビューターガイド

技術スタック
python
領域
backendcli
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Python basicsconfig file handling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue is about the installer skipping authorization when a config file exists but lacks a valid token. The fix involves checking the token validity before skipping the authorization step. Relevant files likely include the install script and auth web.py. The single comment may provide additional context. The expected behavior is to verify token and only skip if valid.
Reusing the config file on install skips authorization · alexa-pi/AlexaPi#186 | Good First Issue