alex-saunders/npm-ui

Split up the Scripts container into its component parts

Open

#17 opened on 2018年1月9日

GitHub で見る
 (1 comment) (1 reaction) (0 assignees)JavaScript (2 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (11 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Bug or Feature?

Feature / Improvement

Current Situation

The Scripts container is getting big as all functionality for the entire view is contained within this container.

Intended Change

We should split up the container and create components for its various parts, to held separate out concerns. The container should simply connect to the redux store and pass properties/functions down to its children, there should be little more functionality than that for the container.

To complete this, the following needs to be done

  • Create components for the container's various parts
  • Pass redux store properties/dispatch methods down to these components
  • Ensure components have the correct functionality

コントリビューターガイド