akka/akka-http

Java DSL methods on ws.Message should be hidden from Scala

Open

#927 opened on 2017年3月5日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Scala (1,311 stars) (598 forks)batch import
1 - triagedhelp wantedt:coret:java

説明

The Scala DSL requires pattern matching to deal with TextMessage vs. BinaryMessage. Calling the content-assisted options leads to the Java side of things with mystifying error messages and lots of head scratching (e.g. folding over the stream with Scala 2.11 and being told that Function2 is expected where I am clearly supplying a 2-ary lambda expression).

The Java DSL methods are just misleading and should not show up on the Scala type. This can be achieved by making them private[akka], which translates to public for Java and is binary compatible.

It might be desirable to either document this better or add methods for the Scala DSL as well.

コントリビューターガイド

技術スタック
scala
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Scala programmingAkka HTTP module structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Locate the `ws.Message` class in the Akka HTTP repository. Identify the Java DSL methods that are currently public and change their visibility to `private[akka]` to hide them from Scala while keeping them accessible from Java. Verify that the change is binary compatible. No linked PRs exist, and the issue has one comment that may provide additional context.