akka/akka-http

Bump h2spec external binary to newer versions

Open

#3,534 opened on 2020年10月15日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Scala (1,311 stars) (598 forks)batch import
help wantednice-to-have (low-prio)t:http2

説明

In #1578 there was some initial work to update the build to use a newer version of https://github.com/summerwind/h2spec/. That work focused on the build.

I've just replaced the binary in ./akka-http2-support/target/h2spec_darwin_amd64/h2spec with the latest and ran H2SpecIntegrationSpec. Tests, as they are now, fail because the binary API has changed from:

https://github.com/summerwind/h2spec/tree/9b3d1a5078cb4003506bd8004eb1b01e3be2a3e7

to

https://github.com/summerwind/h2spec/#usage

The parameter -s: Section number on which to run the test. (Example: -s 6.1 -s 6.2) is not available in h2spec since version 2.0.0. As a consequence, the execution of H2SpecIntegrationSpec goes over tests we don't need taking (a lot) longer and reporting failures we would ignore anyway.

コントリビューターガイド

技術スタック
なし
領域
testingbuild system
Issue 種別
chore
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic understanding of HTTP/2Familiarity with h2spec tool
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the current h2spec CLI changes between version 1.x and 2.x. The old API used s to specify sections, which is no longer available. Update the H2SpecIntegrationSpec test configuration to use the new CLI arguments, likely involving different flags or a separate configuration file. Check the h2spec repository usage documentation for the correct syntax and adapt the test runner accordingly.