akka/akka-core

MetricsCollector.apply() does not report exceptions from custom collector creation

オープン

#27,673 opened on 2019/09/10

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Scala (3,547 件のフォーク)batch import
1 - triagedhelp wanted

Repository metrics

Stars
 (13,277 個のスター)
PR merge metrics
 (平均マージ 8d 19h) (30d で 10 merged PRs)

説明

When custom collector class is specified and fallback collector is allowed, MetricsCollector.apply() attempts to instantiate it in a TryNative. If it fails, it simply instatiates the fallback collector without reporting the problem. It should log the exception with stack trace.

We've discovered by accident that some of our non-critical metrics were not collected because of this --- without any indication in the logs.

コントリビューターガイド