akka/akka-core

Scalafix followups: Move doc specs to doc/jdoc package

オープン

#26,045 opened on 2018/12/05

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)Scala (3,547 件のフォーク)batch import
1 - triagedhelp wantedt:docs

Repository metrics

Stars
 (13,277 個のスター)
PR merge metrics
 (平均マージ 8d 19h) (30d で 10 merged PRs)

説明

https://github.com/akka/akka/pull/26019#pullrequestreview-181636601 introduced scalafix to remove unused imports. It is not enabled on compile and can remove imports that are included in specs for docs.

To followup:

  • Ignore files in doc/jdoc package
  • Move any doc specs to the doc for Scala and jdoc package so that imports are necessary e.g. FlowZipSpec is in the akka.stream.scaladsl and is used for docs. The unit test parts should remain but the docs part should be in a new file in the docs package do that imports from akka.stream.scaladsl are required
  • Test how fast it is to enable on compile and decide if we want it enabled by default

コントリビューターガイド