ajaxorg/ace

XML Syntax Error Indication on a Wrong Line

Open

#3,479 opened on 2017年12月11日

GitHub で見る
 (9 comments) (0 reactions) (0 assignees)JavaScript (26,357 stars) (5,252 forks)batch import
bugeffort/smallgood first issuep2

説明

Tested Browsers / Devices

Windows 10

  • FAIL:
    • Chrome 63.0.3239.84
    • Edge 41.16299.15.0
    • IE 11
    • Firefox 57.0.1
  • OK: n/a

URL Minimal Example

https://ace.c9.io/build/kitchen-sink.html?doc=XML

Steps to Reproduce the Problem

  1. Open an XML document to edit
  2. Optional: If it's not already the case, separate a single-lined XML tag into multiple LOC
  3. Add a syntax error intentionally e.g. a character right after an attribute value: "..."s.

What Is the Expected Result?

ace editor xml expected error indication placement The error / warning indication is on the same line as where the error actually placed.

What Happens Instead?

ace editor xml wrong error indication placement

Any other information?

Even with an XML tag which has all the attributes in a single line, the indication is placed somewhere else which is weird. ace editor xml wrong error indication placement even with a single line I had a case where I made such a syntax error and didn't know where it was until I had to scroll down.

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic knowledge of Ace editorFamiliarity with JavaScriptUnderstanding of XML syntax error handling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate the XML mode in Ace, specifically the file lib/ace/mode/xml highlight rules.js and how error markers are computed. Check the tokenization process and see why the error indicator is placed on a wrong line when a syntax error occurs after an attribute value. Review existing comments on the issue for hints. The bug appears to be in the error positioning logic that does not account for line breaks in multi line tags.