airbnb/react-sketchapp

Introduce `Page.Container` component

Open

#342 opened on 2018年5月30日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)TypeScript (14,970 stars) (900 forks)batch import
enhancementgood first issuehelp wanted

説明

Right now the Page component acts a flex container, allowing to render Artboard's and SymbolMaster's in either a column or a row.

I'd like however to have unlimited flexibility rendering Pages by composing Flex components. By having some sort of arbitrary Flex container, I could layout items on a Page in complex grids if necessary.

This would require us introducing a new Component that can be utilized to compute Yoga layout, but doesn't actually result in any backed rendering.

@mathieudutour - I know this goes against some of your comments in #291, but I'm not sure how else to achieve this.

note: it doesn't need to be called Flex.

コントリビューターガイド

技術スタック
reacttypescript
領域
frontenddesign
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
ReactTypeScriptreact sketchapp API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Examine the existing Page component in react sketchapp to understand its current flex container behavior. Review the discussion in issue #291 about layout flexibility, especially comments from @mathieudutour. The goal is to create a new container component (e.g., Flex) that computes Yoga layout without rendering anything. Look at the Yoga layout integration in the codebase, likely in the yoga layout package, and consider naming and API design.