airbnb/epoxy

Use default value from kotlin setter in a model view

Open

#598 opened on 2018年10月30日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Java (8,412 stars) (738 forks)batch import
help wanted

説明

In @ModelView components setting default values is a pain, since the annotation @ModelProp has to take a string reference by name of a constant.

With kotlin's native support of default values, ideally the generated epoxy model could call a no-arg version of the setter to have the default value used.

The annotation processor and generated code would have to be updated for this. Main issues I see are having the annotation processor know if a default value is present (I think there is a kotlin metadata library we can use for that), and since the generated model is in java it needs to be able to access the no arg version of the function, so many jvmoverloads is required, but it would be nice to not need that

コントリビューターガイド

技術スタック
kotlinjavaandroid
領域
mobile
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Experience with Epoxy libraryUnderstanding of annotation processingKotlin language basicsFamiliarity with JVM overloads
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Investigate the Epoxy annotation processor codebase, specifically the handling of @ModelProp. Use the Kotlin metadata library to detect default values. Consider implementing a no arg setter call in the generated Java model class. Check if JvmOverloads annotation is required and how it interacts with the generated code. Look at existing issues or PRs related to Kotlin default values for guidance.