adobe/react-spectrum

onCancel should fire in AlertDialog if Escape is pressed

Open

#1,773 opened on 2021幎4月7日

GitHub で芋る
 (7 comments) (0 reactions) (0 assignees)TypeScript (1,500 forks)auto 404
good first issue

Repository metrics

Stars
 (15,634 stars)
PR merge metrics
 (PR metrics pending)

説明

🐛 Bug Report (or maybe feature request?)

When adding an onCancel handler to an AlertDialog, it should fire if the dialog is closed via the Escape key.

See here for a repro: https://codesandbox.io/s/adoring-meadow-7cl4c?file=/src/App.js

Open the dialog, click Cancel, dialog will close, you'll see 'Canceled' in the console. Open the dialog, press Escape key, dialog will close, no 'Canceled' in the console.

コントリビュヌタヌガむド