actualbudget/actual

[Tech Enhancement] Implement standard sizes on `Button` component

Open

#3,770 opened on 2024年11月3日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (7,129 stars) (603 forks)batch import
help wanteduser interface

説明

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Currently, there is no standard button sizes across the app. This enhancement is to extend the Button2 component to have a size prop which accepts some standard size values:

  • small
  • medium
  • large
  • extra-large

These standard sizes should vary between screen sizes e.g. different set of width and height for desktop, tablet, mobile

This change should help make all the buttons more uniform in sizes throughout the app

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

コントリビューターガイド

技術スタック
javascriptreactcss
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
React component knowledgeCSS responsive design
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
Start by locating the Button2 component file in the repository. Understand how it currently accepts props and applies styles. Look for any existing size related patterns or theming in the codebase. Then, design a responsive approach using CSS media queries or the project's preferred styling method to handle different screen sizes for each size variant.