actualbudget/actual

[Bug]: Changing mobile transaction amount leads to unexpected amount

Open

#3,194 opened on 2024年8月4日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (7,129 stars) (603 forks)batch import
buggood first issuehelp wantedresponsivetransactions

説明

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When adding new transactions on the mobile PWA, if the backspace button is used to modify the amount, the amount is egregiously large.

Couple of workarounds seem to work in the meanwhile:

  • Click on another menu item like Payee and return to the amount field to enter the correct amount.
  • Long press backspace to force delete the amount and start typing with "0" as the first entry.

I have also attached a video of the bug showing both workarounds.

https://github.com/user-attachments/assets/aba71e12-70cc-4bb3-a2a0-7ca9ea274f67

Where are you hosting Actual?

Pikapods

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Operating System

Mobile Device

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactJavaScriptMobile input handling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Investigate the mobile transaction amount input component, likely in the `packages/desktop client/src/components/modals/` directory. Look for how the amount is updated on each keystroke, especially handling of backspace. The issue suggests that when backspace is pressed, the amount becomes large, likely due to incorrect parsing or state update logic. Check the input's onChange handler and how it processes digits and backspace. Consider using a controlled input with proper value sanitization. Also review any existing tests for this component.