WordPress/gutenberg
Add ESLint rule to prevent usage of the order CSS property
クローズ
#61,247 opened on 2024/04/30
Good First Issue[Focus] Accessibility (a11y)[Status] In Progress[Type] Code Quality
Repository metrics
- Stars
- (9,607 個のスター)
- PR merge metrics
- (平均マージ 12d 18h) (30d で 509 merged PRs)
説明
Description
See https://github.com/WordPress/gutenberg/issues/61241
Some components come with CSS in JS.
https://github.com/WordPress/gutenberg/issues/61241 and https://github.com/WordPress/gutenberg/pull/61243 aim to introduce a stylelint rule to prevent usage of the order CSS property, which is impactful for accessibility.
In the same way, it would be nice to add an ESLint rule to prevent usage of the order CSS property in any *.js file.
Unfortunately this isn't exactly my area of expertise so that I'd appreciate some guidance. I did see a similar rule added in https://github.com/WordPress/gutenberg/pull/58130
Step-by-step reproduction instructions
- Add an
orderCSS property e.g.order: 1;to any CSS-in-JS for example in this file.. - Run
npm run lint:js. - Observe the linter does not report any error.
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes