NumberControl: Disable dragging on touch devices · WordPress/gutenberg#38865

(2 comments) (3 reactions) (0 assignees)JavaScript (9,607 stars) (3,893 forks)batch import

Good First Issue[Package] Components[Status] In Progress[Type] Bug

説明

The drag-to-change-value gesture will not work nicely on touch devices unless we disable browser scrolling with touch-action: none.

There is a separate question of whether we really want this dragging gesture on touch devices, because there is no cursor affordance like on desktop. It’s also pretty easy to accidentally flick and change the value, when you just want to tap/move the caret or something.

I’m inclined to disable the drag gesture on touch devices.

Tested on iPhone (Mobile mode in DevTools has different behavior)

コントリビューターガイド

技術スタック: javascriptreactcss
領域: frontend
Issue 種別: feature
難度: 2
推定時間: 1-3 hours
活動状況: fresh
明確さ: clear
前提条件: Knowledge of React componentsCSS touch action propertyUnderstanding of touch events
初心者向け度: 80
調査方針: Look into the NumberControl component in the Gutenberg repository, likely in packages/components/src/number control/. The issue suggests adding `touch action: none` to disable browser scrolling during drag, and potentially conditionally disabling the drag gesture on touch devices. Check the existing event handlers and CSS for the component. The issue mentions using `use gesture` library, so examine how the drag event is set up. A maintainer may have additional input in the comments.