Testing: Add integration test which ensures that npm packages can be used with Node · WordPress/gutenberg#17273

(9 comments) (1 reaction) (0 assignees)JavaScript (9,607 stars) (3,893 forks)batch import

Good First IssueNeeds Dev[Status] In Progress[Type] Automated Testing[Type] Enhancementnpm Packages

説明

This should prevent bugs like #17165 where a naked reference to window will crash if used in a SSR context where there's no window.

See more details in the comment from @jsnajdr https://github.com/WordPress/gutenberg/pull/17165#issuecomment-525193133:

In this case, the easiest TDD-style test would be to simply import @wordpress/compose in a Node.js environment without DOM. And it would fail.

Neither compose nor components packages use the sideEffects: false flag (although they would be a good fit IMO), so using anything from compose bundles the whole library.

And the window check is a top-level statement in the module. We don't need to use or instantiate the useReducedMotion hook at all to get a broken build.

コントリビューターガイド

技術スタック: javascriptnodejs
領域: testingbackend
Issue 種別: test
難度: 3
推定時間: half day
活動状況: stale
明確さ: clear
前提条件: basic JavaScriptNode.js environmentnpm
初心者向け度: 60
調査方針: Review the linked PR #17165 and the comment from @jsnajdr for context on the `window` reference issue. Examine the `@wordpress/compose` package to identify top level `window` usage. Create a Node.js integration test that imports the package without a DOM environment to ensure no crashes. Consider adding the test to the existing test suite for npm packages.