WordPress/gutenberg

Allow the PanelColorSettings to be visible if no colors and but with children

Open

#12,583 opened on 2018年12月4日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)JavaScript (9,607 stars) (3,893 forks)batch import
Good First IssueNeeds Dev[Package] Components[Type] Enhancement

説明

Is your feature request related to a problem? Please describe. With the PanelColorSettings, if the color prop is empty, the entire panel stops rendering. However, if PanelColorSettings has children, they won't show anymore also if the color prop is empty. I expect that the panel would still show up if it has children even with no color options available.

Describe the solution you'd like The PanelColorSettings should only hide if there are no color options AND no children. Right now is only checks the number of color options.

Describe alternatives you've considered I tried creating my own PanelColorSettings component to address this, but it uses a lot of unexposed / private components.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactJavaScriptWordPress/Gutenberg basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Locate the PanelColorSettings component in the Gutenberg repository, likely in packages/components/src. Examine the component's render method where it currently returns null if there are no color settings. Modify the conditional to also check for the presence of children (props.children) and render the component if children exist, even if color settings are empty. Test the change by setting the colors prop to empty but passing children to ensure they render.