VSCodeVim/Vim

Editor is undefined

Open

#3,033 opened on 2018年9月7日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)TypeScript (12,664 stars) (1,271 forks)batch import
good first issuehelp wanted

説明

Describe the bug The property 'editor' can be undefined (see Screenshots section).

To Reproduce Steps to reproduce the behavior:

  1. Start VSCode
  2. Check Breakpoints > Promise Rejects and Breakpoints > Uncaught Exceptions
  3. Start my extension in debug mode (Debugger > Launch client). I believe, that can be reproduced with any extension, though it happened to me during development of mine plugin.
  4. If any file is opened after start, close all of them and start again.

Expected behavior The absence of the error.

Screenshots debugger

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 0.16.3
  • VSCode version: 1.27.1
  • OS: Ubuntu 16.04

Additional context

コントリビューターガイド

技術スタック
typescript
領域
developer experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic TypeScriptVSCode extension API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Investigate the code at src/mode/modeHandler.ts line 1324 where `editor` is accessed without a null check. Review the context to understand when `editor` could be undefined, such as when no file is open. Add a guard clause to handle the undefined case, perhaps by returning early or providing a fallback. Test the fix by starting VSCode with no files open and triggering the debug steps described in the issue.