TeamNewPipe/NewPipe

Increase tablet mode breakpoint

オープン

#6,067 opened on 2021/04/13

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Java (3,577 件のフォーク)batch import
GUIfeature requestgood first issue

Repository metrics

Stars
 (38,153 個のスター)
PR merge metrics
 (平均マージ 9d 17h) (30d で 17 merged PRs)

説明

Checklist

Describe the feature you want

Currently, NewPipe determines whether tabled mode should be used based whether the smallest width is <480dp or >=480dp.

According to the the Android developer guide (https://developer.android.com/training/multiscreen/screensizes) the breakpoint should be at 600dp. They have the following quantifiers there:

  • 320dp: a typical phone screen (240x320 ldpi, 320x480 mdpi, 480x800 hdpi, etc).
  • 480dp: a large phone screen ~5" (480x800 mdpi).
  • 600dp: a 7” tablet (600x1024 mdpi).
  • 720dp: a 10” tablet (720x1280 mdpi, 800x1280 mdpi, etc).

This is also consistent with e.g. the Android System UI, which switches into tablet mode at a smallest width of >=600dp.

Is your feature request related to a problem? Please describe it

I run my phone with a smallest width of ~500dp. This defaults NewPipe into tablet mode. PR #6059 fixes the problem for me, but I think the automatic tablet mode threshold is not where it should be.

How will you/everyone benefit from this feature?

This is a really small fix (literally just change a number) and causes phones with larger screens to be detected as phones. I am pretty sure there is no tablet out there with a (default) smallest width of <600dp.

コントリビューターガイド