Supervisor/supervisor

Eventlistener protocol "len" header changed in Supervisor 4

Open

#1,243 opened on 2019年5月23日

GitHub で見る
 (33 comments) (0 reactions) (0 assignees)Python (7,941 stars) (1,233 forks)batch import
eventshelp wanted

説明

@plockaby wrote comments of issue #1235:

Migrating from version 3 to version 4, my event listeners read from supervisor over stdin using a byte stream and then did the conversion to utf8 and chose to "backslashreplace" undecodable utf8 data. When I went to version 4 I expected to continue to get a byte stream that I could convert myself to whatever encoding I knew the data to be in. It was really unexpected to discover that supervisor was doing the conversion for me and then telling me the number of characters to read off of stdin and not the number of bytes.

cc: @vsajip

コントリビューターガイド

技術スタック
python
領域
backendapi
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Knowledge of PythonUnderstanding of Supervisor event listener protocol
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
Investigate the change in the 'len' header from bytes to characters in Supervisor's event listener protocol. Review the pull request discussion at PR #1235 and the referenced issue #1235. Look at the supervisor/events.py or similar files where stdin reading and header parsing occurs. Determine if the conversion to characters is intentional or a bug, and consider adding a configuration option to preserve byte based behavior.