StackGuardian/tirith

🐛 cli.py: return non zero code when final evaluation returns false

オヌプン

#89 opened on 2022/11/28

 (0 件のコメント) (0 件のリアクション) (0 人の担圓者)Python (41 件のフォヌク)auto 404
buggood first issuehacktoberfest

Repository metrics

Stars
 (168 個のスタヌ)
PR merge metrics
 (PR metrics pending)

説明

Describe the bug tirith always return zero code even when the final evaluator returns false (failed)

To Reproduce I was using these files: plan.json.txt apigateway_state_logging_enabled.tirith.json.txt

Steps to reproduce the behavior:

  1. Download and rename both of the files above, from .txt to .json
  2. Run tirith -policy-path apigateway_state_logging_enabled.tirith.json -input-path plan.json
  3. The final evaluation should be failed
  4. Check the return code by doing echo $?
  5. It will print 0 instead of 1

Expected behavior It should return non-zero code as it will make the caller of the program knows that tirith final evaluation has failed

コントリビュヌタヌガむド