SortableJS/Sortable

[bug] Can't cancel swap once an item has been hovered over

Open

#1,866 opened on 2020年7月15日

GitHub で見る
 (13 comments) (5 reactions) (0 assignees)JavaScript (30,389 stars) (3,731 forks)batch import
Swapenhancementgood first issue

説明

Describe the bug

When using the Swap plugin, it's impossible to cancel a swap once the swap threshold has been met for an item. You can't drag the item back to its original place to prevent a swap. This happens with or without the revertOnSpill: true option.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://sortablejs.github.io/Sortable/#swap
  2. Drag "Item 1" to hover over "Item 2", triggering Item 2 to get highlighted. Don't drop "Item 1", but instead try to prevent a swap by moving Item 1 back to its original place.
  3. See: It's not possible to prevent a swap.

Expected behavior

Dragging Item 1 back to its original place, or off of the list, should deactivate the swap.

Information

Sortable.version == 1.10.2

I didn't include a code sandbox since it's visible with Sortable.js's own Github site.

Thank you so much for your work on this library!

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic understanding of Sortable.js swap plugin
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Investigate the Swap plugin's event handling in the Sortable.js codebase. The issue is that once the swap threshold is met, the swap cannot be undone. Look at the `onDrag` or `onMove` callbacks in the plugin's source code, likely in `plugins/Swap.js`. Check if there is a condition that prevents reverting when `revertOnSpill` is true. The fix might involve allowing a cancellation of the swap when the dragged item returns to its original position or leaves the list.