Semantic-Org/Semantic-UI-React

Dropdown scroll position going top when adding options

Open

#3,721 opened on 2019年7月26日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
help wantedneeds engineering

説明

Hello,

I did search in the 30+ issues opened but did not see anything similar. Here is the bug I've encountered :

Bug Report

When modifying options of a Dropdown while you are scrolling inside of it, the scroll position going full top.

Expected Result

Scroll staying on actual position

Actual Result

Scroll reseting to top

Version

SUIR@0.87.3

Testcase

In this Testcase, I simulated addition of elements when clicking on a button. FYI, in my reality case, I am doing an infinite scroll, which is adding elements when needed.

https://codesandbox.io/s/semantic-ui-react-example-1xvv7?fontsize=14

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactSemantic UI React basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue reports that the Dropdown component's scroll position resets to top when its options are modified while scrolling. The testcase in the issue shows adding options via a button. The likely cause is that the component re renders and resets the scroll position. Investigate the Dropdown component source code, typically in `src/modules/Dropdown/Dropdown.js`. Look for how the scroll position is managed, possibly via a ref or state. The fix may involve preserving the scroll position before re render and restoring it after. Check if there are any lifecycle methods or hooks that handle this. Since the issue is old and unassigned, no linked PRs or comments exist.