Semantic-Org/Semantic-UI-React

Search: preventing event bubbling leading to unexpected behaviour

Open

#3,118 opened on 2018年8月29日

GitHub で見る
 (7 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wantedstale

説明

Bug Report

Steps

Render any other component which is normally expected to close when clicked outside (e.g. Popup) Click on Search component The other component (e.g. Popup) does not close on clicking on Search component

Expected Result

Other components (e.g Popup) that rely on window onclick listener to close when clicked outside its area must be able to close

Actual Result

Search component prevents event bubbling and other components (e.g Popup) are not closed when clicking on Search component

Version

0.82.3

Testcase

CodeSandbox to replicate the issue

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
React event handlingEvent bubblingSemantic UI React components
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the Search component's event handlers in the Semantic UI React source code to identify where event.stopPropagation() is being called. Compare with the Popup component's behavior to understand the expected event flow. Review the linked CodeSandbox testcase to replicate the issue. Check issue comments for any proposed solutions or discussions.
Search: preventing event bubbling leading to unexpected behaviour · Semantic-Org/Semantic-UI-React#3118 | Good First Issue