RFC: Popup more intuitive behavior with multiple `on` events · Semantic-Org/Semantic-UI-React#2765

(8 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import

enhancementhelp wanted

説明

Bug Report

The problem happens when using multiple events to trigger Popup. Can be reproduced with <Popup trigger={<button>Show tooltip</button>} content='tooltip' on={['click', 'hover']} but the easiest way is with <Popup trigger={<button>Show tooltip</button>} content='tooltip' on={['click', 'focus']}. Just try clicking the button. For the first time, it opens the popup and immediately closes it. Following clicks work correctly. This problem has been mentioned in #2075 by @austinfox here.

Steps

Go to Semantic UI React Popup demo.
Edit e.g. first example Popup component to contain multiple on events i.e. on={['click', 'focus']}.
Click the popup trigger.

Expected Result

Popup is displayed and stays open.

Actual Result

Popup is displayed and closed immediately.

Version

0.80.0

Testcase

Check the steps section above.

コントリビューターガイド

技術スタック: javascriptreactcss
領域: frontend
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: React knowledgeEvent handling basics
初心者向け度: 70
調査方針: Investigate the Popup component's event handling logic in the source code, specifically how it manages multiple `on` event types. Check the linked comment in issue #2075 for previous discussion. The fix likely involves ensuring that when multiple events are specified, the popup does not close immediately after opening due to event propagation or state management issues. Look at the Popup component file in the repository, possibly `src/modules/Popup/Popup.js`.