Semantic-Org/Semantic-UI-React

Rework TransitionablePortal callbacks for consistency

Open

#2,423 opened on 2018年1月10日

GitHub で見る
 (9 comments) (0 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
bughelp wanted

説明

Steps

  1. Create a controlled <TransitionablePortal />
  2. Toggle the open prop from false to true
  3. Trigger a close with ESC or click outside

Expected Result

  1. On prop change to open, the onOpen callback should not be called. This is a programmatic prop change, not a trigger click.
  2. When a close event is triggered, the onClose callback should be called before starting the transition as the user may choose to disregard the close request.

Actual Result

  1. On prop change to open, onOpen is called at the beginning and end of the open transition
  2. When a close event is triggered, the onClose callback is called after the onHide callback. There is no way to handle the close request and ignore it.

See the test case for proposed fixes.

Version

0.77.2

Testcase

https://codesandbox.io/s/rj8qv1yl2o

コントリビューターガイド

技術スタック
reactjavascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of React component lifecycleBasic knowledge of callback patterns
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Examine the TransitionablePortal component's source code, likely in src/modules/TransitionablePortal. Review the test case provided in the CodeSandbox to understand the current callback behavior. Check the comments on the issue for any proposed solutions or maintainer input. The goal is to reorganize when onOpen and onClose callbacks are triggered to match the expected behavior described in the issue.