Semantic-Org/Semantic-UI-React

Popup's do not work with modal's when dimmers are enabled.

Open

#1,803 opened on 2017年6月27日

GitHub で見る
 (21 comments) (10 reactions) (0 assignees)JavaScript (13,136 stars) (4,065 forks)batch import
help wantedneeds engineeringstale

説明

This is a follow up to this issue: https://github.com/Semantic-Org/Semantic-UI-React/issues/1545

The submitter was forwarded to /Semantic-UI I followed up in this post: https://github.com/Semantic-Org/Semantic-UI/issues/5440

It turns out that the issue has to do with the order the the popups/modals are created in. /Semantic-UI responded that pre-existing modals should be used for this. As far as i know, there's no way to achieve that in the current react variant of the UI.

Thank you :)

Steps

  • Create a modal with a dimmer setting that's not false.
  • Place a pop up inside the modal

Expected Result

Hovering over trigger displays the popup on top of the modal

Actual Result

Popup displays behind the modal, even behind the dimmer actually!

Version

0.70.0

Testcase

https://codepen.io/eGust/pen/zZXomK

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
React basicsSemantic UI React components
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue is about popups appearing behind modals when dimmers are enabled. A testcase is provided at https://codepen.io/eGust/pen/zZXomK. The root cause is likely a z index conflict or portal ordering. Examine the Popup and Modal component source files in the repository to understand how they manage stacking contexts. Consider using React portals to properly layer popups on top of modals. Related issues #1545 and Semantic UI/Semantic UI#5440 provide additional context.