RicoSuter/NSwag

Bug - NSwag generates bad code for an enum

Open

#2,883 opened on 2020年6月9日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)C# (6,291 stars) (1,189 forks)batch import
help wantedproject: NJsonSchemaproject: NJsonSchema.CodeGeneration.CSharpproject: NJsonSchema.CodeGeneration.TypeScripttype: bug

説明

I have 2 DTOs, both contain same Enum image

I have 2 controller methods using those DTO as URL query args image

I have 2 swagger definitions with same Enum image

And I get bad code from NSwag with "2" added to Enum name image

If this is not a bug then what am I doing wrong? Also this seem to be wrong only on method signature of the generated interface and the class, once I remove "2" the code compiles and I think it's generally ok code

image

コントリビューターガイド

技術スタック
csharptypescript
領域
toolingapi
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of NSwagBasic knowledge of C# and TypeScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Investigate how NSwag handles enum naming when the same enum appears in multiple DTOs. Look at the TypeScript client generation code in the NSwag repository, specifically the part that assigns names to enums. The issue shows that an enum gets a '2' suffix, likely due to a naming conflict resolution. Check if there is a collision detection mechanism and why it fails. Also review the two comments on the issue for any additional insights. Consider reproducing the issue with a minimal example to confirm the behavior.