libfuturize.fixes.fix_absolute_import duplicates initial comments · PythonCharmers/python-future#281

(1 comment) (0 reactions) (0 assignees)Python (1,172 stars) (327 forks)batch import

0.19bughelp wanted

説明

precondition

Create thing/{__init__.py,foo.py,bar.py}

Fill foo.py with the following:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
import bar

run fix_absolute_import on thing

expected

foo.py should have become:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from __future__ import absolute_import
from . import bar

observed

foo.py has actually become:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from __future__ import absolute_import
#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from . import bar

コントリビューターガイド

技術スタック: python
領域: toolingdeveloper experience
Issue 種別: bug
難度: 2
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: Python basicsUnderstanding of libfuturize
初心者向け度: 70
調査方針: The bug is in the `fix absolute import` fixer within `libfuturize.fixes`. The issue is that when processing a file with initial comments, the fixer duplicates those comments after inserting the `from future import absolute import` line. Look at the logic that handles the initial comment block and the insertion point for the future import. The expected behavior is to insert the future import without duplicating the comments. Investigate the relevant file (likely `libfuturize/fixes/fix absolute import.py`) and the method that inserts imports, possibly by checking if comments are being re added unnecessarily. The fix might involve ensuring that the comment block is only written once. The issue is clear from the provided example, and no maintainer input is required.