Seal traits inside `impl_` submodule · PyO3/pyo3#3908

(13 comments) (0 reactions) (0 assignees)Rust (10,152 stars) (668 forks)batch import

Good First Issue

説明

Off the back of https://github.com/PyO3/pyo3/pull/3897#discussion_r1504721475

Should we review the traits inside the impl_ submodule, check which ones can be sealed, and do that? It's a reasonable safety mechanism to prevent users from trying to implement those things.

コントリビューターガイド

技術スタック: rust
領域: backenddeveloper experience
Issue 種別: feature
難度: 3
推定時間: half day
活動状況: active
明確さ: clear
前提条件: Knowledge of Rust's sealed trait patternFamiliarity with PyO3's `impl ` submodule
初心者向け度: 45
調査方針: Start by examining the `impl ` submodule in the pyo3 crate's source code. Review the discussion in PR #3897, especially the comment at the linked line, to understand which traits are candidates for sealing. Then, implement a private sealed trait marker (e.g., a hidden supertrait) and modify the trait definitions in the `impl ` submodule to require that marker. Ensure that the sealing does not break existing functionality and is backward compatible. The issue does not specify all traits to seal, so you may need to propose a list and get feedback from maintainers.