ProjectEvergreen/greenwood

refactor project to use JSON Modules

オープン

#1,015 opened on 2022/12/02

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (15 件のフォーク)auto 404
CLIPluginsenhancementgood first issue

Repository metrics

Stars
 (132 個のスター)
PR merge metrics
 (PR metrics pending)

説明

After the upgrade to #1014 for Node v18 support, we can now refactor all instances of reading a JSON file to use native JSON modules, using import assertions

// before
const packageJson = JSON.parse(fs.readFileSync('./package.json', 'utf-8'));
const greenwoodPackageJson = JSON.parse(await fs.promises.readFile(new URL('../package.json', import.meta.url), 'utf-8'))

// after
import packageConfig from './package.json' assert { type: 'json' };

So goal would be to go and replace all those instances to the new version.


This will also require us updating our ESLint version to include support for import assertions, which we might still need to wait for? https://github.com/eslint/eslint/discussions/15305

Or maybe we can get around it with a plugin?

コントリビューターガイド