PrestaShop/PrestaShop

Improve eslint disabled lines

オープン

#27,979 opened on 2022/03/19

 (4 件のコメント) (0 件のリアクション) (0 人の担当者)PHP (4,734 件のフォーク)batch import
BODeveloper FeatureFront-endGood first issueHacktoberfestImprovementReady

Repository metrics

Stars
 (7,621 個のスター)
PR merge metrics
 (平均マージ 26d 17h) (30d で 116 merged PRs)

説明

Prerequisites

Is your feature request related to a problem?

Actually, there are 59 fully ESLint disabled lines

We can improve it by making it more specific to the error we need to disable

Describe the solution you'd like

Before: // eslint-disable-next-line

After: // eslint-disable-next-line max-len

Disabling every rules is a wrong practice because it's hiding some others errors that could be important to know

This work can be separated into multiple batches:

Back-office

  • Default
  • New theme

Front-office

  • Classic
  • Hummingbird

Alternatives you've considered

No response

Additional context

Acceptance Criteria

  • Verify that the line is forced to be disabled because sometime the line could be disabled without any real reasons
  • If it's the case, just ignore the specific rule instead of disabling every ESLint errors

Do you plan to work on this feature?

  • I'm willing to contribute a formal specification.
  • I'm willing to provide any wireframes or design assets required for this feature.
  • I'm willing to submit a Pull Request that implements this feature.
  • I'm willing to help verify that the implemented feature works as intended and produces no unintended side effects.

コントリビューターガイド