PointCloudLibrary/pcl

Kinfu MarchingCubes writes unbounded data to hardcode sized buffer

オープン

#719 opened on 2014/05/31

 (12 件のコメント) (0 件のリアクション) (1 人の担当者)C++ (4,506 件のフォーク)batch import
help wantedkind: bugmodule: gpuskill: cudastatus: stale

Repository metrics

Stars
 (9,023 個のスター)
PR merge metrics
 (平均マージ 8d 7h) (30d で 3 merged PRs)

説明

pcl::gpu::MarchingCubes::run:

  if (triangles_buffer.empty())
    triangles_buffer.create(DEFAULT_TRIANGLES_BUFFER_SIZE);
DEFAULT_TRIANGLES_BUFFER_SIZE = 2 * 1000 * 1000 * POINTS_PER_TRIANGLE

marching_cubes.cu/store_point():

triangles_buffer[index] = ...; // index is dependent on how many voxels we have

I suggest changing DEFAULT_TRIANGLES_BUFFER_SIZE to WHY_WOULD_ANYONE_EVER_HAVE_MORE_TRIANGLES, that will make the out of bounds crash on the GPU much easier to find.

I also like how it starts with 2 * - that looks almost like somebody thought "hmm for some reason the code works if I make this bigger".

コントリビューターガイド