PointCloudLibrary/pcl
Inconsistent handling of default seed in NormalGenerator & UniformGenerator
オープン
#2,985 opened on 2019/04/09
effort: lowgood first issuekind: todoneeds: feedback
Repository metrics
- Stars
- (9,023 個のスター)
- PR merge metrics
- (平均マージ 8d 7h) (30d で 3 merged PRs)
説明
As already discussed here default seed in random.h is not handled consistently.
One constructor of NormalGenerator has as default seed -1 during the other one (via Parameters) has 1 as default seed.
Furthermore you get currently following warning:
common/include/pcl/common/impl/random.hpp:49:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if(parameters_.seed != -1)
So we should discuss how to adjust code there.